Review: 7105780: Add SSLSocket client/SSLEngine server to templates directory (original) (raw)

Brad Wetmore bradford.wetmore at oracle.com
Mon Oct 31 18:47:44 UTC 2011

Done, thanks.

Brad

On 10/28/2011 6:59 PM, Xuelei Fan wrote:

It's a good idea to move it to template directory. I did quick look at the code, looks fine to me. I did not read the code line by line carefully, hopefully, there is no significant changes from previous test.

Just a minor suggest, it would be better if moving the @run tag at the bottom of the comment. Otherwise, the "SunJSSE does not support ..." would become the parameters of the command. I just noticed the issue recently. * @summary Add SSLSocket client/SSLEngine server to templates directory -* @run main/othervm SSLSocketSSLEngineTemplate * * SunJSSE does not support dynamic system properties, no way to * re-use system properties in samevm/agentvm mode. +* @run main/othervm SSLSocketSSLEngineTemplate */ Thanks, Xuelei On 10/29/2011 8:48 AM, Brad Wetmore wrote: Hi Andrew,

Wrapping up some loose ends. I was thinking it would be a good idea to put the test case for the recent Bad MAC error into the JSSE test template directory. It might be useful to have a SSLSocket client that can easily talk to a SSLEngine server. If we keep this test buried down in sun/security/ssl/com/sun/net/ssl/internal/ssl/SSLEngineImpl, it'll easily be forgotten. I made a few very minor changes to the test: 7105780: Add SSLSocket client/SSLEngine server to templates directory http://cr.openjdk.java.net/~wetmore/7105780/webrev.00/ What do you think? Brad

More information about the security-dev mailing list