Code review request: 7190945: pkcs11 problem loading NSS libs on Ubuntu (original) (raw)

Xuelei Fan xuelei.fan at oracle.com
Mon Aug 13 11:31:08 UTC 2012

Looks fine to me.

A very very minor comment about the potential exception. Before the update, if the NSS libraries was not found, I think the exception may looks like: java.io.FileNotFoundException: /usr/lib/libnss3.so

But with this update, I think it may looks like: java.io.FileNotFoundException: /usr/lib/nss/libnss3.so

I would like the fore as "/usr/lib" is the normal location of a lib file. I was wondering, can we just fail back to the normal case if the library in Unbuntu does not exist.

410 File libraryFile = new File(libraryDir, libraryName); 411 if (!libraryFile.isFile()) { 412 File failover = new File(libraryDir, "nss/" + libraryName);

413 } 414 this.libraryName = libraryFile.getPath();

It is pretty trivial suggestion, I'm OK with your current fix.

Xuelei

On 8/13/2012 6:39 PM, Vincent Ryan wrote:

Please review these changes to correct a problem loading Mozilla NSS on multi-arch Ubuntu:

http://cr.openjdk.java.net/~vinnie/7190945/webrev.00/ Thanks.

More information about the security-dev mailing list