Code review request for JEP-121 (original) (raw)
Valerie (Yu-Ching) Peng valerie.peng at oracle.com
Fri Aug 31 02:05:02 UTC 2012
- Previous message (by thread): Code review request for JEP-121
- Next message (by thread): hg: jdk8/tl/jdk: 7193710: ByteArrayOutputStream Javadoc contains unclosed
element - Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Vinnie,
- Is it possible to replace the CipherCore object w/ CipherSpi object so to maximize the code re-use? The new code uses CipherSpi object for RC4 and CipherCore for RC2. Perhaps by using CipherSpi for both RC4 and RC2, we can have less code which would be easier to maintain...
- the impls of the two following engineInit() methods are inconsistent, i.e. engineInit(int, Key, AlgorithmParameterSpec, SecureRandom) - expects IvParameterSpec engineInit(int, Key, AlgorithmParameters, SecureRandom) - expects objects created from PBEParameterSpec
- The impl of engineGetParameters() currently returns objects created from PBEParameterSpec. It should return whatever is expected in the engineInit(...) calls, I'd think.
Will send you the rest of comments later, Valerie
On 08/29/12 08:20, Vincent Ryan wrote:
On 06/ 1/12 07:18 PM, Vincent Ryan wrote:
Hello Valerie,
Could you please review these changes for JEP-121: http://cr.openjdk.java.net/~vinnie/6383200/webrev.00/ Thanks. The latest webrev is now available at: http://cr.openjdk.java.net/~vinnie/6383200/webrev.02/ I've incorporated review comments and made some fixes to the implementation of AES-based PBE algorithms. Thanks.
- Previous message (by thread): Code review request for JEP-121
- Next message (by thread): hg: jdk8/tl/jdk: 7193710: ByteArrayOutputStream Javadoc contains unclosed
element - Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]