Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done (original) (raw)
Vincent Ryan vincent.x.ryan at oracle.com
Wed Feb 8 11:42:58 UTC 2012
- Previous message (by thread): Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done
- Next message (by thread): Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thanks for your review.
On 02/ 8/12 09:35 AM, Xuelei Fan wrote:
Looks fine to me.
Interesting fix that making use of the class loading priorities. Xuelei On 2/8/2012 5:18 PM, Vincent Ryan wrote: Please review the following change: http://cr.openjdk.java.net/~vinnie/7142339/webrev.00/
for http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7142339 It employs lazy initialization to avoid the overhead of creating a secure random number generator in code that never uses signature timestamping. Thanks.
- Previous message (by thread): Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done
- Next message (by thread): Code review request: 7142339: PKCS7.java is needlessly creating SHA1PRNG SecureRandom instances when timestamping is not done
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]