RFR for CR 7179879 : SSLSocket connect times out instead of throwing socket closed exception (original) (raw)
Xuelei Fan xuelei.fan at oracle.com
Thu Jul 26 02:37:12 UTC 2012
- Previous message (by thread): RFR for CR 7179879 : SSLSocket connect times out instead of throwing socket closed exception
- Next message (by thread): RFR for CR 7179879 : SSLSocket connect times out instead of throwing socket closed exception
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks fine to me.
Thanks, Xuelei
On 7/26/2012 9:49 AM, Seán Coffey wrote:
Requesting a review for the following issue :
http://bugs.sun.com/viewbug.do?bugid=7179879 The SSLSocketImpl doesn't appear to handle the case where a connect operation is cancelled before an SSL session has begun (we simple ignore such a case) Fix would be to honour the close call which interrupts the connect request and close out the socket with the appropriate socket closed exception. webrev : http://cr.openjdk.java.net/~coffeys/webrev.7179879.jdk8/ <http://cr.openjdk.java.net/%7Ecoffeys/webrev.7179879.jdk8/> I've run the testcase manually and verified the fix. I've attempted to automate the testcase but had issue in getting an SSLServerSocket to not over eagerly accept a client socket connect request (client connect succeeding even before server code makes an accept call) Regards, Sean.
- Previous message (by thread): RFR for CR 7179879 : SSLSocket connect times out instead of throwing socket closed exception
- Next message (by thread): RFR for CR 7179879 : SSLSocket connect times out instead of throwing socket closed exception
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]