[PATCH] Review request for 7195733 TEST_BUG: sun/security/ssl/sun/net/www/protocol/https/HttpsURLConnection/B6216082.java failing (original) (raw)

Weijun Wang weijun.wang at oracle.com
Wed Sep 5 01:47:41 UTC 2012

I don't update copyright years myself also these days.

Not all changes in JDK 8 will be backported to 7u, so if you always update copyright years, some patch won't apply smoothly. For example, you made a change in 2011, the patch is

you made another change to the same file in 2012, the patch is

Now suppose only the 2nd fix is backported to 7u. Since the year in the 7u file is still 2010, patching fails.

Thanks Max

On 09/05/2012 03:48 AM, Brad Wetmore wrote:

On 9/3/2012 3:20 AM, Alan Bateman wrote: On 03/09/2012 11:02, Eric Wang wrote: Hi Chris and Xuelei,

Thanks for your advice, I have updated the @run tag and copyright, please help to review. and Thank you to be my sponsor. http://dl.dropbox.com/u/90659131/fixes/7195733/webrev/index.html Looks fine to me too (note that you aren't required to change the copyright date, it doesn't matter if you do or don't but once it can cause clutter in patches. Didn't parse this. "Once it can cause clutter in patches?" Instead there is supposed to regular batch updating of the copyright dates, something that I don't see very often but is supposed to happen). -Alan

More information about the security-dev mailing list