JDK8 Code review request for 7199939 and 7199941 (original) (raw)
Valerie (Yu-Ching) Peng valerie.peng at oracle.com
Fri Sep 21 23:45:08 UTC 2012
- Previous message (by thread): hg: jdk8/tl/jdk: 7199551: (bf) CharBuffer.append(CharSequence) throws BufferOverflowException for read-only buffer
- Next message (by thread): JDK8 Code review request for 7199939 and 7199941
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi, Vinnie,
Can you please review these following 2 JDK8 fixes? They are straight forward regressions found by SQE tests introduced as byproducts of the NSA Suite B changes. Since they are already caught by existing SQE tests, so I didn't add more regression tests.
7199939 <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199939>: DSA 576 ad 640 bit keys fail when initializing for No precomputed parameters Webrev: http://cr.openjdk.java.net/~valeriep/7199939/webrev.00/ Fix: Fixed the impl of DSAKeyPairGenerator.initialize(int, SecureRandom) so it will attempt to generate new parameters (instead of error out) when no precomputed parameters are available. Also fixed ParameterCache.getNewDSAParameterSpec(...) method to handle legacy DSA key sizes.
7199941 <http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7199941>: test about AES/ECB mode fails Webrev: http://cr.openjdk.java.net/~valeriep/7199941/webrev.00/ Fix: Moved the initialization of the field 'blockMode' back to the right code block.
The failed SQE tests now pass after the code changes.
Thanks! Valerie
-------------- next part -------------- An HTML attachment was scrubbed... URL: <https://mail.openjdk.org/pipermail/security-dev/attachments/20120921/08e5032a/attachment.htm>
- Previous message (by thread): hg: jdk8/tl/jdk: 7199551: (bf) CharBuffer.append(CharSequence) throws BufferOverflowException for read-only buffer
- Next message (by thread): JDK8 Code review request for 7199939 and 7199941
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]