[8] Code review request for 8005408: KeyStore API enhancements (original) (raw)

Vincent Ryan vincent.x.ryan at oracle.com
Tue Jan 22 22:40:33 UTC 2013


On 22/01/2013 17:05, Vincent Ryan wrote:

I've made those changes. Thanks.

On 22 Jan 2013, at 16:24, Sean Mullan wrote: :>>>> KeyStore.java

[296] I think you want to say: If none was set then null is returned. As I understand it, if none is set, then the KeyStore provider will use a default algorithm as specified by the Security property. This needs to be made clearer in the javadoc, as it reads it says it returns the value of this property, which is not possible since this class doesn't know what keystore type is being used at this point. That's right. I want to add that behaviour but I need to think about it further.

I've clarified the spec for the KeyStore.getProtectionAlgorithm method:

/**

[304] specify that null can be returned - @return the algorithm name, or null if none was set --Sean



More information about the security-dev mailing list