Code review request: 8015274, 8015276 and 8016158: policytool manual test problems (original) (raw)

Weijun Wang weijun.wang at oracle.com
Tue Jun 11 13:51:56 UTC 2013

It is because of

8015274: TEST_BUG: Step2: After selecting 'View Warning Log', it is

empty instead of FileNotFound.

Policytool automatically loads ~/.java.policy when it's started. The test expects the file does not exist and a warning should be created.

-Max

On 6/11/13 9:16 PM, Sean Mullan wrote:

Why did you need to check for a $HOME/.java.policy file in i18n.sh? Can you explain that?

Otherwise, changes look good to me. --Sean On 06/08/2013 09:32 PM, Weijun Wang wrote: Updated at

http://cr.openjdk.java.net/~weijun/8015274/webrev.01/ A new bug 8016158 is added. The changes include: 1. Add CYGWIN* as a case for uname in all tests 2. Add description about temp directory in all tests 3. i18.sh now checks for ~/.java.policy and creates a keystore 4. Many changes in i18n.html, keystore URLs, some warning now does not show. I personally run i18n.sh on Mac and Windows. Every step looks fine now. Thanks Max

On 5/31/13 9:41 AM, Weijun Wang wrote: Please review the fix at http://cr.openjdk.java.net/~weijun/8015274/webrev.00/ It's for two bugs: 8015274: TESTBUG: Step2: After selecting 'View Warning Log', it is empty instead of FileNotFound. 8015276: TESTBUG: The 'ptool.test' can't be saved in the 'tmp' folder. Thanks Max

More information about the security-dev mailing list