[8] code review request for 7165807: Non optimized initialization of NSS crypto library leads to scalability issues (original) (raw)
Sean Mullan sean.mullan at oracle.com
Wed Jun 19 17:21:27 UTC 2013
- Previous message (by thread): [8] code review request for 7165807: Non optimized initialization of NSS crypto library leads to scalability issues
- Next message (by thread): [8] code review request for 7165807: Non optimized initialization of NSS crypto library leads to scalability issues
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks good, just a couple of comments:
I think the name "nssOptimizeSpace" is clearer. The "Use" part seems a bit odd in the property name.
Add the appropriate noreg label to the bug.
File a followup doc bug to document the attribute in the PKCS11 guide.
--Sean
On 06/19/2013 08:49 AM, Vincent Ryan wrote:
I've made some corrections to the native method that initializes NSS. The new webrev is at:
http://cr.openjdk.java.net/~vinnie/7165807/webrev.01
On 14 Jun 2013, at 18:38, Vincent Ryan wrote: Please review the following fix: http://cr.openjdk.java.net/~vinnie/7165807/webrev.00/ http://bugs.sun.com/viewbug.do?bugid=7165807 NSS may be initialized to favour performance or to favour memory footprint. This fix introduces a new configuration flag to allow Java applications to choose. By default, NSS will be initialized for performance. Thanks.
- Previous message (by thread): [8] code review request for 7165807: Non optimized initialization of NSS crypto library leads to scalability issues
- Next message (by thread): [8] code review request for 7165807: Non optimized initialization of NSS crypto library leads to scalability issues
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]