Webrev request: JDK-8015081 (original) (raw)

Wang Weijun weijun.wang at oracle.com
Wed Jun 11 02:24:03 UTC 2014


Hi Jamil

Sorry I've just read the webrev.

If you always throw an NPE after a collectionNullClean() call, isn't it simpler to let the method throw the NPE?

Also, Objects.requireNonNull(o, msg) can be used in those "if (o == null)" cases.

Thanks Max

On Jun 10, 2014, at 23:32, Sean Mullan <sean.mullan at oracle.com> wrote:

Looks good to me.

--Sean On 06/06/2014 06:16 PM, Jamil Nimeh wrote: One more version of this webrev with minor comment changes:

http://cr.openjdk.java.net/~ascarpino/8015081/webrev.04 Thanks, --Jamil



More information about the security-dev mailing list