RFR 8046702: default_options.sh test failure on Solaris (original) (raw)
Xuelei Fan Xuelei.Fan at Oracle.Com
Thu Jun 12 15:12:34 UTC 2014
- Previous message (by thread): RFR 8046702: default_options.sh test failure on Solaris
- Next message (by thread): (smartcardio) Confusing bug fix for wrong DWORD typedef
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Looks fine to me.
Xuelei
On Jun 12, 2014, at 10:57 PM, Wang Weijun <weijun.wang at oracle.com> wrote:
Oh, I made the mistake again, on Solaris "export ENV=var" is not always correct. Please review the code change at http://cr.openjdk.java.net/~weijun/8046702/webrev.00/ The fix is as simple as -----START----- diff --git a/test/sun/security/tools/keytool/defaultoptions.sh b/test/sun/security/tools/keytool/defaultoptions.sh --- a/test/sun/security/tools/keytool/defaultoptions.sh +++ b/test/sun/security/tools/keytool/defaultoptions.sh @@ -38,7 +38,8 @@ rm $KS 2> /dev/null -export PASS=changeit +PASS=changeit +export PASS # keytool -----END----- I was using "-storepass changeit" but at the final second I changed it to export PASS=changeit keytool -storepass:env PASS and thought it looks more secure. I should have run it on all platforms again. Thanks Max
- Previous message (by thread): RFR 8046702: default_options.sh test failure on Solaris
- Next message (by thread): (smartcardio) Confusing bug fix for wrong DWORD typedef
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]