code review for 7067811: Update demo/sample code to state it should not be used for production (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Thu Aug 11 08:58:58 PDT 2011

Nils Loodin wrote:

Added a comment in each demo source file stating that the code below is unfit for production. Made a separate comment blog from the copyright one to make it stand out more and be more warning-like :)

http://cr.openjdk.java.net/~nloodin/7067811/webrev.00/ /Nisse Nils - is it just demo code or do you plan to do this to sample code too (sample code is in src/share/sample/**)? One thing that isn't clear to me is why this needs to be added to every file. Seems like a warning in each demo's README should be sufficient.

One specific file in the webrev that might need special treatment is hprof_b_spec.h. That header file is essentially the "spec" to the HPROF binary format (sad I know). It just seems a bit strange to add a comment saying that it "has been deliberately simplified" to this file specifically.

-Alan.

More information about the serviceability-dev mailing list