code review for 7067811: Update demo/sample code to state it should not be used for production (original) (raw)

Mandy Chung mandy.chung at oracle.com
Fri Aug 12 12:57:00 PDT 2011

On 08/11/11 08:58, Alan Bateman wrote:

Nils Loodin wrote:

Added a comment in each demo source file stating that the code below is unfit for production. Made a separate comment blog from the copyright one to make it stand out more and be more warning-like :)

http://cr.openjdk.java.net/~nloodin/7067811/webrev.00/ /Nisse Nils - is it just demo code or do you plan to do this to sample code too (sample code is in src/share/sample/**)? One thing that isn't clear to me is why this needs to be added to every file. Seems like a warning in each demo's README should be sufficient.

I agree with Alan that README in each demo would be a proper and adequate place to add this warning. In addition, there is a typo "suich" in the third line of the warning:

* required for a production-quality application, suich as security checks,

Is this intentional? Or a typo should be fixed?

Mandy

More information about the serviceability-dev mailing list