java.nio.BufferPoolMXBean getObjectName() occasionally returns null (original) (raw)
Steve Poole spoole at linux.vnet.ibm.com
Tue Aug 23 02:36:31 PDT 2011
- Previous message: java.nio.BufferPoolMXBean getObjectName() occasionally returns null
- Next message: hg: jdk8/tl/jdk: 6476261: (reflect) GenericSignatureFormatError When signature includes nested inner classes; ...
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On Tue, 2011-08-23 at 10:11 +0100, Alan Bateman wrote:
Mandy Chung wrote: > Steve, > > I have prepared a patch from your contribution [1] to fix: > 7068328: BufferPoolMXBean and PlatformLoggingMXBean getObjectName > may return null > > Webrev at: > http://cr.openjdk.java.net/~mchung/7068328/webrev.00/ > > I have modified the fix to move the "result = objname" assignment > before the check to construct the ObjectName and also cover the > logging mxbean. Are you okay with this? > > Serviceability team, > May I get a reviewer for this patch? I won't count myself as a > reviewer as I modify the fix. > Thanks for picking this up.
At L175 then this can be "if (result == null)" to avoid reading objname again. Same thing at L233. The test looks fine. -Alan.
Mandy, Alan - thanks for completing this work. I hadn't forgotten just not got round to it :-(. I like the new testcase BTW. Now I have a great example for the future
Steve
- Previous message: java.nio.BufferPoolMXBean getObjectName() occasionally returns null
- Next message: hg: jdk8/tl/jdk: 6476261: (reflect) GenericSignatureFormatError When signature includes nested inner classes; ...
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]