Need reviewer: a couple of hprof fixes for Parfait (original) (raw)

David Holmes david.holmes at oracle.com
Mon Jun 11 22:56:10 PDT 2012

On 12/06/2012 12:48 PM, Kelly O'Hair wrote:

Need reviewer. I was asked to look at some Parfait errors in hprof code: 7176138: Fixes for missing close() calls and possible null pointer reference instead of fatal error http://cr.openjdk.java.net/~ohair/openjdk8/parfaithproffixes/webrev/

hprof_table.c

211 if ( ltable->info_size == 0 ) { 212 HPROF_ERROR(JNI_TRUE, "Table is empty and should never be."); 213 return NULL;

It is not obvious this should be a fatal error. Elsewhere this is handled as an assert.

David

More information about the serviceability-dev mailing list