URGENT code review request for Solaris FDS fix (7175255) (original) (raw)

Kelly O'Hair kelly.ohair at oracle.com
Tue Jun 19 18:58:21 PDT 2012

130 ( set -e ;
131 cd 64 ;
132 (QUIETLY)(QUIETLY) (QUIETLY)(ADD_GNU_DEBUGLINK)
133 (LIBJVMDBDEBUGINFO)(LIBJVM_DB_DEBUGINFO) (LIBJVMD​BD​EBUGINFO)(LIBJVM_DB) ;
134 ) Would be better as: 130 ( cd 64 && (ADDGNUDEBUGLINK)(ADD_GNU_DEBUGLINK) (ADDG​NUD​EBUGLINK)(LIBJVM_DB_DEBUGINFO) $(LIBJVM_DB) )

And making GENERATED a full path scares me. That variable is used all over the place. Are we sure all uses are ok being full paths?

And shouldn't this 64 directory name be in a variable to make it more obvious? Maybe LIBJVM_DIRNAME64=64?

Is this a last minute change that is expected to be extremely low risk? Doesn't feel low risk. :^( Sorry.

-kto

On Jun 19, 2012, at 6:21 PM, Daniel D. Daugherty wrote:

Greetings,

This is an URGENT code review request for a Solaris specific Full Debug Symbols (FDS) fix. Due to a Makefile logic error, the full debug symbol files and related 'g' symlinks are created in the wrong sub-directory for a couple of the dtrace libraries. The incorrect paths have a double "64/" sub-directory, e.g.: solaris-/jre/lib//client/64/64/libjvmdb.debuginfo These are the correct symlink paths: solaris-/fastdebug/jre/lib//client/64/libjvmgdb.debuginfo solaris-/fastdebug/jre/lib//client/64/libjvmgdtrace.debuginfo solaris-/fastdebug/jre/lib//server/64/libjvmgdb.debuginfo solaris-/fastdebug/jre/lib//server/64/libjvmgdtrace.debuginfo and these are the correct debug info file paths: solaris-/jre/lib//client/64/libjvmdb.debuginfo solaris-/jre/lib//client/64/libjvmdtrace.debuginfo solaris-/jre/lib//server/64/libjvmdb.debuginfo solaris-/jre/lib//server/64/libjvmdtrace.debuginfo solaris-/fastdebug/jre/lib//client/64/libjvmdb.debuginfo solaris-/fastdebug/jre/lib//client/64/libjvmdtrace.debuginfo solaris-/fastdebug/jre/lib//server/64/libjvmdb.debuginfo solaris-/fastdebug/jre/lib//server/64/libjvmdtrace.debuginfo where "" is "i586" or "sparc". The 64-bit Solaris platforms ("amd64" and "sparcv9") don't have this issue because they don't have the "64/" sub-directories. This fix is targeted at HSX-24/JDK8 and HSX-23.2/JDK7u6 and will resolve an issue that is preventing Oracle's Release Engineering scripts from running properly. Here is the webrev URL for the HSX-24/JDK8 version: http://cr.openjdk.java.net/~dcubed/fdsrevamp/7175255-webrev/0/ The HSX23.3/JDK7u6 version is the same except for the changes to make/solaris/makefiles/defs.make which are not needed in HSX23.2. Thanks, in advance, for any reviews! Dan

More information about the serviceability-dev mailing list