RFR (XS): 8007901 SA: Don't read flag values as constants (original) (raw)

David Holmes david.holmes at oracle.com
Mon Feb 11 16:20:51 PST 2013

On 10/02/2013 5:06 AM, Staffan Larsen wrote:

Please review this small patch to avoid reading flag values in SA as constants. Reading them as constants means SA will only see the default value for these flags. Instead the infrastructure in SA to read command line flags should be used. In addition the value if EnableInvokeDynamic is never used, so I removed that from SA.

Isn't the real problem in the way db is initialized with the values for these flags? ie shouldn't db.lookupIntConstant("UseTLAB").intValue() be returning the actual value of UseTLAB as it occurs in the VM ?

Also we need a regression test for this as obviously it ain't being tested! :(

Thanks, David

webrev: http://cr.openjdk.java.net/~sla/8007901/webrev.00/ bug: http://bugs.sun.com/viewbug.do?bugid=8007901 (not yet visible)

Thanks, /Staffan

More information about the serviceability-dev mailing list