code review round 0 for minor FDS makefile fix (8033714) (original) (raw)
Daniel D. Daugherty daniel.daugherty at oracle.com
Wed Feb 5 15:20:52 PST 2014
- Previous message: Why do we need both - export maps AND -fvisibility=hidden/__attribute__((visibility("default")))
- Next message: code review round 0 for minor FDS makefile fix (8033714)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
This code review request is going to three different aliases. Don't use Thunderbird's "reply to list" option since it will pick just one of the three lists.
Greetings,
Doug Simon and Tom Rodriguez have sent a Full Debug Symbols (FDS) makefile fix our way. Here are the bug and webrev URLs:
http://cr.openjdk.java.net/~dcubed/8033714-webrev/0-jdk9-hs-runtime/
8033714 hotspot 'install_jvm' bld target broken with ZIP_DEBUGINFO_FILES=0 https://bugs.openjdk.java.net/browse/JDK-8033714
As you might guess from the bug synopsis, this fix is needed when building without ZIP'ing the debuginfo files (ZIP_DEBUGINFO_FILES=0). Based on the Graal project fix, I've updated a few other places where building with FDS disabled is affected.
As always, comments and suggestions are welcome.
Dan
- Previous message: Why do we need both - export maps AND -fvisibility=hidden/__attribute__((visibility("default")))
- Next message: code review round 0 for minor FDS makefile fix (8033714)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]