code review round 0 for minor FDS makefile fix (8033714) (original) (raw)

David Holmes david.holmes at oracle.com
Wed Feb 5 20:28:44 PST 2014

Hi Dan,

Looks good to me. (I never run the install targets :( )

Thanks, David

On 6/02/2014 9:20 AM, Daniel D. Daugherty wrote:

This code review request is going to three different aliases. Don't use Thunderbird's "reply to list" option since it will pick just one of the three lists.

Greetings, Doug Simon and Tom Rodriguez have sent a Full Debug Symbols (FDS) makefile fix our way. Here are the bug and webrev URLs: http://cr.openjdk.java.net/~dcubed/8033714-webrev/0-jdk9-hs-runtime/ 8033714 hotspot 'installjvm' bld target broken with ZIPDEBUGINFOFILES=0 https://bugs.openjdk.java.net/browse/JDK-8033714 As you might guess from the bug synopsis, this fix is needed when building without ZIP'ing the debuginfo files (ZIPDEBUGINFOFILES=0). Based on the Graal project fix, I've updated a few other places where building with FDS disabled is affected. As always, comments and suggestions are welcome. Dan

More information about the serviceability-dev mailing list