8034856/8034857: More gcc warnings (original) (raw)

Alan Bateman Alan.Bateman at oracle.com
Wed Feb 19 09:07:04 PST 2014

On 18/02/2014 19:45, Mikael Vidstedt wrote:

That makes sense, and in fact parsemanifest.c does not even appear to allow for \t, so I'm more and more starting to think that a reasonable implementation in this context would be: static int isNormalSpace(int c) { return c == ' '; } In which case it probably shouldn't even be a separate function to start with. I would like to get a second opinion on the implications of only checking for ' ' (0x20) though. If we want to allow both ' ' and \t we should probably call the function isblankAscii. Thanks again for taking this. On \t then if it's nor handled by the parsing code then isNormalSpace should be fine.

-Alan. -------------- next part -------------- An HTML attachment was scrubbed... URL: http://mail.openjdk.java.net/pipermail/serviceability-dev/attachments/20140219/aaa8c604/attachment.html

More information about the serviceability-dev mailing list