Review request for 7146146: Deadlock between subclass of AbstractDocument and UndoManager (original) (raw)
Artem Ananiev artem.ananiev at oracle.com
Fri Apr 6 10:19:18 UTC 2012
- Previous message: Review request for 7146146: Deadlock between subclass of AbstractDocument and UndoManager
- Next message: Review request for 7154030: java.awt.Component.hide() does not repaint parent container
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi, Pavel,
the fix looks fine, except code formatting: some of the added/changed lines are too long, which makes the code less readable.
Thanks,
Artem
On 4/5/2012 7:59 PM, Pavel Porvatov wrote:
Hi,
This is a review request for CR 7146146 Bug description: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7146146 Webrev: http://cr.openjdk.java.net/~rupashka/7146146/webrev.0/ Evaluation of the problem: We should do any notifications outside of internal locks. The solution is to correct AbstractDocument#insertString method and move fireInsertUpdate and fireUndoableEditUpdate invocations from writeLock/writeUnlock block Regards, Pavel
- Previous message: Review request for 7146146: Deadlock between subclass of AbstractDocument and UndoManager
- Next message: Review request for 7154030: java.awt.Component.hide() does not repaint parent container
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]