Reviewer needed: fix for TitledBorder class (original) (raw)
Pavel Tisnovsky ptisnovs at redhat.com
Fri Apr 27 09:14:58 UTC 2012
- Previous message: hg: jdk8/swing/jdk: 7129742: Unable to view focus in Non-Editable TextArea
- Next message: Reviewer needed: fix for TitledBorder class
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi,
I think there's a bug in a TitledBorder class. According to JavaDoc the methods getTitleColor() and getTitleFont() should use look&feel settings when nothing is explicitly changed by constructor/setters:
If the border, font, or color property values are not specified in the constuctor or by invoking the appropriate set methods, the property values will be defined by the current look and feel, using the following property names in the Defaults Table: "TitledBorder.border" "TitledBorder.font" "TitledBorder.titleColor"This behaviour were removed by following changeset: changeset: 2529:d062afbe2107 user: malenkov date: Thu Jul 01 18:09:45 2010 +0400 summary: 4129681: Cannot get a title border to display its label as disabled
Here is a webrew which contains fix for this issue: http://cr.openjdk.java.net/~ptisnovs/TitledBorder/
Can anybody please review this fix? (I'd like to push the same change to OpenJDK7 too it it will be reviewed & accepted)
Thank you in advance, Pavel Tisnovsky
- Previous message: hg: jdk8/swing/jdk: 7129742: Unable to view focus in Non-Editable TextArea
- Next message: Reviewer needed: fix for TitledBorder class
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]