[7u8] Review request for 7193219: JComboBox serialization fails in JDK 1.7 (original) (raw)

Pavel Porvatov pavel.porvatov at oracle.com
Tue Aug 28 17:45:31 UTC 2012

Hi Anton,

The fix looks good but the test should be updated:

  1. Is the following line needed for the test: 63 frame.setVisible(true);

? If yes then you should use SunToolkit.realSync to wait until frame become visible. The same comment for the line 85 frame.setVisible(true);

  1. Are label and layout and layout needed for the test purpose? If no, can you remove unused components?

  2. The following code looks strange (two titles?) 45 JFrame frame = new JFrame("HelloWorldSwing"); ... 47 frame.setTitle("why why why");

  3. The test method should be on the EDT

  4. There is no need to use the mainPanel field. Logically it should be local variable

BTW: can you start with the fix for jdk8 and only then backport it to jdk7?

Regards, Pavel

Hello,

Please review the following fix for a bug. Bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7193219 Webrev: http://cr.openjdk.java.net/~alitvinov/7193219/webrev.01 For details on this bug please look at "Evaluation" field on a web page of this bug. The provided webrev contains both a fix and a corresponding unit-test. Before publishing this webrev all unit-tests from the "java.awt" and "javax.swing" related to serialization were run and no negative changes were observed comparing the results of tests' runs on JDK with and without patch represented by this webrev. This is the second version of the fix. The first version was submitted to the AWT development group through a review request with the same subject and after discussion with engineers and additional investigation of the problem it was decided to apply the fix in Swing part of JDK. Thank you, Anton

More information about the swing-dev mailing list