[8] Review request for JDK-6757986: javax/swing/JInternalFrame/5066752/bug5066752.java needs correction (original) (raw)
Sergey Bylokhov Sergey.Bylokhov at oracle.com
Thu Dec 13 18:31:21 UTC 2012
- Previous message: [8] Review request for JDK-6757986: javax/swing/JInternalFrame/5066752/bug5066752.java needs correction
- Next message: [8] Review request for JDK-7132383: [macosx] bug6596966.java should be adapted for Mac
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi, Vera. Fix looks good.
11.12.2012 18:53, vera akulova wrote:
Hello Sergey,
Thanks for your reply, I created new webrev: http://cr.openjdk.java.net/~kshefov/6757986/webrev.01 (typo near tag @test fixed, real coordinates are used to get color now) Thanks, Vera On 11.12.2012 16:11, Sergey Bylokhov wrote: Hello, Vera. setBounds() can be ignored by native system, I suggest to fetch real coordinates from the window instead of 50,50. Also bug5066752 is a typo in 24 @test bug5066752 ?
10.12.2012 19:29, vera akulova wrote: Hello,
Please review a fix for the issue: JDK-6757986: javax/swing/JInternalFrame/5066752/bug5066752.java needs correction The webrev is http://cr.openjdk.java.net/~kshefov/6757986/webrev.00/ The manual test from closed repo was automated. Fixed test works fine on windows, linux, solaris and macos. Thanks, Vera.
-- Best regards, Sergey.
- Previous message: [8] Review request for JDK-6757986: javax/swing/JInternalFrame/5066752/bug5066752.java needs correction
- Next message: [8] Review request for JDK-7132383: [macosx] bug6596966.java should be adapted for Mac
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]