[8] Review request for 7151823: The test incorrectly recognizing OS (original) (raw)

Anton Litvinov anton.litvinov at oracle.com
Mon Jun 3 10:12:45 UTC 2013

Hello Alexander,

Thank you for the review of this fix and information about "hitMnemonics()" method from the class "Util.java". Yes, surely, the next time when I need to press mnemonic keys using "java.awt.Robot" I will use this method. I supposed that in this particular bug, I had just to correct a used way of platform detection.

Thank you, Anton

On 6/3/2013 1:52 PM, Alexander Scherbatiy wrote:

The fix looks good for me. Next time you could use hitMnemonics() method form the swing regtesthelpers Util class that uses system mnemonics keys. Thanks, Alexandr.

On 6/2/2013 1:30 PM, Anton Litvinov wrote: Hello,

Please review the following fix for the bug. Bug: http://bugs.sun.com/bugdatabase/viewbug.do?bugid=7151823 Webrev: http://cr.openjdk.java.net/~alitvinov/7151823/webrev.00 The bug consists in the fact that a regression test for the bug 4624207 cannot define that it is being run on OS X platform, when Aqua L&F is not used by Java. The fix substitutes detection of the platform by analyzing L&F for usage of "sun.awt.OSInfo.getOSType()" method. Thank you, Anton

More information about the swing-dev mailing list