[PATCH] ObjectInputStream Reading Performance Optimisation (original) (raw)
Ben Walsh ben_walsh at uk.ibm.com
Wed Feb 7 14🔞19 UTC 2018
- Previous message (by thread): [PATCH] ObjectInputStream Reading Performance Optimisation
- Next message (by thread): hg: valhalla/valhalla: Value-based classes (vbc) / Oop value test via metadata ptr
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Okey dokey. I'll resubmit to core-libs-dev. Thanks Alan.
Ben
From: Alan Bateman <Alan.Bateman at oracle.com> To: Ben Walsh <ben_walsh at uk.ibm.com>, David Holmes <david.holmes at oracle.com> Cc: valhalla-dev at openjdk.java.net Date: 07/02/2018 13:29 Subject: Re: [PATCH] ObjectInputStream Reading Performance Optimisation
On 07/02/2018 12:55, Ben Walsh wrote:
Hi David,
I suspected the adding of src/java.base/share/classes/java/io/ClassCache.java and the usage of it, would mean this patch would have to go through the "proving ground" of valhalla. I am happy to resubmit to core-libs-dev if that is not the case or I have misunderstood. Ben I don't have the full context here but core-libs-dev is the place to bring optimizations to serialization. As David said, serialization and OIS/deserialization in particular, has a long rap sheet, including security issues found with previous attempts to cache the "latest user defined class loader". I also have concerns that this is introducing code that may not be exercised in OpenJDK. If you can get someone to publish a webrev on cr.ojn and start a discussion on core-libs-dev then it would be helpful.
-Alan
Unless stated otherwise above: IBM United Kingdom Limited - Registered in England and Wales with number 741598. Registered office: PO Box 41, North Harbour, Portsmouth, Hampshire PO6 3AU
- Previous message (by thread): [PATCH] ObjectInputStream Reading Performance Optimisation
- Next message (by thread): hg: valhalla/valhalla: Value-based classes (vbc) / Oop value test via metadata ptr
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]