[Nestmates] RFR: 8195826: [Nestmates] Cleanup sun/invoke/util/VerifyAccess.java (original) (raw)
David Holmes david.holmes at oracle.com
Mon Jan 29 06:22:09 UTC 2018
- Previous message (by thread): [Nestmates] RFR: 8195826: [Nestmates] Cleanup sun/invoke/util/VerifyAccess.java
- Next message (by thread): [Nestmates] RFR: 8195828: [Nestmates] Remove leftover changes to invokespecial handling that are not needed
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
For the record the code being cleaned up here was incorrect. It doesn't allow for the fact that we may encounter older classfile versions, which rely on the existing non-nestmate related access check. We need to combine the new areNestmates check with the old enclosing-class based isSamePackageMember check.
New bug being filed, and new (or modified existing) test to ensure we check behaviour with older class files.
David
On 22/01/2018 4:31 PM, David Holmes wrote:
Bug: https://bugs.openjdk.java.net/browse/JDK-8195826 webrev: http://cr.openjdk.java.net/~dholmes/8195826/webrev
Get rid of old experimental ALLOWNESTMATEACCESS support and recast directly using Reflection.areNestMates(a,b). Update quote of JVMS 5.4.4 access rules. Thanks, David
- Previous message (by thread): [Nestmates] RFR: 8195826: [Nestmates] Cleanup sun/invoke/util/VerifyAccess.java
- Next message (by thread): [Nestmates] RFR: 8195828: [Nestmates] Remove leftover changes to invokespecial handling that are not needed
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]