RFR(L): 8205044: [lworld] Interpreter and compiler support for acmp with value type operands (original) (raw)

Tobias Hartmann tobias.hartmann at oracle.com
Wed Jul 11 13:43:13 UTC 2018

Hi Roland,

thanks for the review!

On 11.07.2018 15:09, Roland Westrelin wrote:

In compile.cpp:

4652 // Return constant false because one operand is a non-null value type 4653 return new CmpINode(phase->intcon(0), phase->intcon(1)); there must be a better way to return always false.

Yes, here's the incremental webrev: http://cr.openjdk.java.net/~thartmann/8205044/webrev.01_inc/

How is the change in callGenerator.cpp related to acmp?

It's not related to acmp but I found the problem during testing with this patch. If we late inline a method handle linkTo* call, the return value might be a ValueTypeNode although we are expecting an oop. We need to allocate before we can replace the call.

Thanks, Tobias

More information about the valhalla-dev mailing list