RFR: version specific class file parser and verifier fixes (original) (raw)
Harold David Seigel harold.seigel at oracle.com
Wed Jul 18 20:51:06 UTC 2018
- Previous message (by thread): RFR: version specific class file parser and verifier fixes
- Next message (by thread): RFR JDK-8207790: [lworld] update reflection to generate ValueTypes attribute
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Mandy,
Thanks for looking at this.
Go ahead and push your patch first.
I'll then update my patch with needed jdk.internal.reflect.ClassFileAssembler::emitMagicAndVersion changes.
Harold
On 7/18/2018 4:31 PM, mandy chung wrote:
Looks good.
jdk.internal.reflect.ClassFileAssembler::emitMagicAndVersion will need to be updated too after I push the fix for JDK-8207790. We can follow up separately depending on which patch goes first. Mandy On 7/18/18 11:43 AM, Harold David Seigel wrote: Hi,
Please review this LWorld change to ignore the ValueTypes attribute and value type specific access flags for class file versions < 55. This fix also includes changes to the verifier to throw VerifyError exceptions for withfield and defaultvalue opcodes for class file versions < 55. Open Webrev: http://cr.openjdk.java.net/~hseigel/lworld.cfpverf/webrev/ The changes were tested with various tier1 - tier5 Mach5 tests on Linux and Mac. Thanks, Harold
- Previous message (by thread): RFR: version specific class file parser and verifier fixes
- Next message (by thread): RFR JDK-8207790: [lworld] update reflection to generate ValueTypes attribute
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]