RFR JDK-8207815: [lworld] JVM_GetArrayElement and, JVM_SetArrayElement don't work for flatten array (original) (raw)
mandy chung mandy.chung at oracle.com
Thu Jul 19 00:33:44 UTC 2018
- Previous message (by thread): RFR JDK-8207815: [lworld] JVM_GetArrayElement and, JVM_SetArrayElement don't work for flatten array
- Next message (by thread): [lworld] Clean up compiler test cases
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Oops... thanks for catching it. Will fix it before push.
Mandy
On 7/18/18 5:23 PM, John Rose wrote:
If getComponentType is null you need to throw IAE.
You can do this by sending the non-array straight to the native function: - if (!componentType.isPrimitive()) { + if (componentType != null && !componentType.isPrimitive()) {
On Jul 18, 2018, at 5:16 PM, mandy chung <mandy.chung at oracle.com> wrote: Array::get and Array::set call JVMGetArrayElement and JVMSetArrayElement function to get and set an array element. The JVM entry points don't support flattened arrays. Instead of adding the flatten array support in JVMGetArrayElement and JVMSetArrayElement, it's straight-forward to do that in Array::get and Array::set in Java. Webrev: http://cr.openjdk.java.net/~mchung/valhalla/webrevs/8207815/webrev.00/index.html Mandy
- Previous message (by thread): RFR JDK-8207815: [lworld] JVM_GetArrayElement and, JVM_SetArrayElement don't work for flatten array
- Next message (by thread): [lworld] Clean up compiler test cases
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]