Initial runtime support for the ValueTypes attribute (original) (raw)
Karen Kinnear karen.kinnear at oracle.com
Fri May 18 14:16:05 UTC 2018
- Previous message (by thread): Initial runtime support for the ValueTypes attribute
- Next message (by thread): Initial runtime support for the ValueTypes attribute
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Frederic,
Code looks really good. Many thanks for doing this so quickly and carefully. Thank you for the symbol refcount handling.
Summary: declared fields (static and instance): preload, i.e. classfileparser loads before completing container loading linkage to fields and methods, we load at link time prior to creation of vtables/itables
- this all sounds correct to me.
instanceKlass.cpp: 621
- comment is that arrays of value types are not handled
- do we actually need to preload arrays of value types at link time for any optimizations?
Empty.java: line 40: Excepted -> Expected
thanks, Karen
On May 17, 2018, at 4:04 PM, Frederic Parain <frederic.parain at oracle.com> wrote:
Please review this first patch related to the ValueTypes attribute: http://cr.openjdk.java.net/~fparain/VTAttribute/webrev.00/ The patch includes: - the parsing of the ValueTypes attribute - the creation of meta-data from this attribute - a consistency check between the ACCFLATTENABLE flag and the ValueTypes attribute - the pre-loading of method arguments types and return values types Fred
- Previous message (by thread): Initial runtime support for the ValueTypes attribute
- Next message (by thread): Initial runtime support for the ValueTypes attribute
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]