[C++-sig] Useless use of type attributes (original) (raw)
David Abrahams dave at boost-consulting.com
Thu Dec 8 06:37:16 CET 2005
- Previous message: [C++-sig] Useless use of type attributes
- Next message: [C++-sig] Useless use of type attributes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Philipp Thomas <pth at suse.de> writes:
boost/python/detail/wrapperbase.hpp and boost/python/detail/exceptionhandler.hpp needlessly uses type attributes in the forward declaration, which prompts gcc 4.1 to warn with
warning: type attributes are honored only at type definition here's a patch to fix this:
This is another GCC-specific patch. Those macros aren't type attributes, except on GCC, and only when targeting certain platforms. They expand to different things on different compilers. Are you sure that no supported platforms need them? I seem to recall that older versions of MinGW, in fact, had very odd requirements in terms of where those __declspecs were placed.
--- boost/python/detail/exceptionhandler.hpp +++ boost/python/detail/exceptionhandler.hpp @@ -11,7 +11,7 @@
namespace boost { namespace python { namespace detail { -struct BOOSTPYTHONDECL exceptionhandler; +struct exceptionhandler; typedef function2<bool, exceptionhandler const&, function0 const&> handlerfunction; --- boost/python/detail/wrapperbase.hpp +++ boost/python/detail/wrapperbase.hpp @@ -14,7 +14,7 @@ namespace detail { - class BOOSTPYTHONDECL wrapperbase; + class wrapperbase; namespace wrapperbase // ADL disabler {
-- Dave Abrahams Boost Consulting www.boost-consulting.com
- Previous message: [C++-sig] Useless use of type attributes
- Next message: [C++-sig] Useless use of type attributes
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]