[Python-3000] [Python-Dev] Need help fixing failing Py3k Unittests in py3k-struni (original) (raw)
Amaury Forgeot d'Arc amauryfa at gmail.com
Wed Jul 11 21:13:31 CEST 2007
- Previous message: [Python-3000] [Python-Dev] Need help fixing failing Py3k Unittests in py3k-struni
- Next message: [Python-3000] [Python-Dev] Need help fixing failing Py3k Unittests in py3k-struni
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Re-hello,
Thomas Heller wrote:
> On 7/11/07, Amaury Forgeot d'Arc wrote: >> Thomas Heller wrote: >> > I would love to look into these, but I prefer debugging on Windows. >> > However, the windows build does not work because the fileio builtin >> > module is missing from config.c. Again, this is not so easy to fix, >> > because the ftruncate function does not exist on Windows. >> >> In fileobject.c, there is a replacement for ftruncate. See the code >> around the call to SetEndOfFile(). >> >> I'll try to provide a patch later today.
Awaiting your patch ;-).
Ok, here it is; shamelessly copied from fileobject.c. BTW, what is the status of this fileobject? open() doesn't seem to use it anymore. Will file() be removed at some point?
Now test_fileio passes on Windows, with the exception of testAbles(): since c:\dev is an existing directory on my machine, /dev/tty is a regular file and is seekable... Maybe skip this test on win32?
I have a couple of other corrections, found by randomly playing with the tests functions... shall I post the corrections here as well?
-- Amaury Forgeot d'Arc -------------- next part -------------- A non-text attachment was scrubbed... Name: fileio-2.diff Type: application/octet-stream Size: 1681 bytes Desc: not available Url : http://mail.python.org/pipermail/python-3000/attachments/20070711/d18cdd5d/attachment-0001.obj
- Previous message: [Python-3000] [Python-Dev] Need help fixing failing Py3k Unittests in py3k-struni
- Next message: [Python-3000] [Python-Dev] Need help fixing failing Py3k Unittests in py3k-struni
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]