getargs.c (original) (raw)

neal.norwitz python-checkins at python.org
Fri Apr 14 07:20:29 CEST 2006

Previous message: [Python-checkins] r45373 - python/trunk/Misc/developers.txt
Next message: [Python-checkins] r45375 - python/trunk/Lib/test/leakers/README.txt
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

Author: neal.norwitz Date: Fri Apr 14 07:20:28 2006 New Revision: 45374

Modified: python/trunk/Misc/NEWS python/trunk/Python/getargs.c Log: SF Bug #1454485, array.array('u') could crash the interpreter when passing a string. Martin already fixed the actual crash by ensuring Py_UNICODE is unsigned. As discussed on python-dev, this fix removes the possibility of creating a unicode string from a raw buffer.

There is an outstanding question of how to fix the crash in 2.4.

Modified: python/trunk/Misc/NEWS

--- python/trunk/Misc/NEWS (original) +++ python/trunk/Misc/NEWS Fri Apr 14 07:20:28 2006 @@ -12,6 +12,13 @@ Core and builtins

+- Bug #1454485, array.array('u') could crash the interpreter. This was

due to PyArgs_ParseTuple(args, 'u#', ...) trying to convert buffers (strings)
to unicode when it didn't make sense. 'u#' now requires a unicode string.
+- Py_UNICODE is unsigned. It was always documented as unsigned, but
due to a bug had a signed value in previous versions.
- Patch #837242: id() of any Python object always gives a positive number now, which might be a long integer. PyLong_FromVoidPtr and PyLong_AsVoidPtr have been changed accordingly. Note that it has

Modified: python/trunk/Python/getargs.c

--- python/trunk/Python/getargs.c (original) +++ python/trunk/Python/getargs.c Fri Apr 14 07:20:28 2006 @@ -1042,11 +1042,8 @@ STORE_SIZE(PyUnicode_GET_SIZE(arg)); } else { - char *buf; - Py_ssize_t count = convertbuffer(arg, p, &buf); - if (count < 0) - return converterr(buf, arg, msgbuf, bufsize); - STORE_SIZE(count/(sizeof(Py_UNICODE))); + return converterr("cannot convert raw buffers", + arg, msgbuf, bufsize); } format++; } else {

Previous message: [Python-checkins] r45373 - python/trunk/Misc/developers.txt
Next message: [Python-checkins] r45375 - python/trunk/Lib/test/leakers/README.txt
Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]

More information about the Python-checkins mailing list