[Python-Dev] serious bug in new import X as Y code (original) (raw)

Barry A. Warsaw bwarsaw@beopen.com
Fri, 18 Aug 2000 16:45:03 -0400 (EDT)

"TW" == Thomas Wouters <thomas@xs4all.net> writes:

TW> No, and that's one more reason to reverse my patch ! :-) Note
TW> that I didn't *add* the Makefile, I only added Grammar to the
TW> directories-to-run-make-in-by-default. If the Grammar is
TW> changed, you already need a way to run pgen (of which the
TW> source rests in Parser/) to generate the new
TW> graminit.c/graminit.h files. I have no way of knowing whether
TW> that is the case for the windows build files. The CVS tree
TW> should always contain up to date graminit.c/.h files!

I don't think you need to reverse your patch because of this, although I haven't been following this thread closely. Just make sure that if you commit a Grammar change, you must commit the newly generated graminit.c and graminit.h files.

This is no different than if you change configure.in; you must commit both that file and the generated configure file.

-Barry