[Python-Dev] Where is PyMarshal_ReadShortFromFile() ? (original) (raw)

Tim Peters tim.one@home.com
Thu, 11 Oct 2001 18:04:15 -0400

[Tim]

Please submit as a patch to SourceForge, including doc and test case changes.

[James C. Ahlstrom]

OK, done.

Thanks!

But both functions are undocumented and neither is in testmarshal.py.

Then you've included the doc and test changes .

They are internal C utilities.

Not so: you're making a bad situation worse. If an extern name doesn't begin with "_", it's part of Python's public C API, and should be documented and tested. I don't think anyone will let that hold up your patch, although everyone probably should.

including-me-on-both-counts-ly y'rs - tim