[Python-Dev] OS/2 VAC++ patches (original) (raw)
Andrew MacIntyre andymac@bullseye.apana.org.au
Tue, 30 Oct 2001 23:15:28 +1100 (EDT)
- Previous message: [Python-Dev] Slices and "==" optimization
- Next message: [Python-Dev] 2.2 article updated
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I have looked at Michael Muller's VAC++ patches, and added comments as followups.
In summary: 473749 - has several (minor IMO) stylistic issues (addition of OS/2 #ifdefs). The intent of the changes looks OK, as do most of the actual changes (those in OS/2 VAC specific files or existing OS/2 #ifdefs). 474169 - looks good to go (changes inside existing OS/2 #ifdef) 474500 - looks good to go (isolated to OS/2 specific file)
Comments on the stylistic issues?
-- Andrew I MacIntyre "These thoughts are mine alone..." E-mail: andymac@bullseye.apana.org.au | Snail: PO Box 370 andymac@pcug.org.au | Belconnen ACT 2616 Web: http://www.andymac.org/ | Australia
- Previous message: [Python-Dev] Slices and "==" optimization
- Next message: [Python-Dev] 2.2 article updated
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]