[Python-Dev] [#527371] sre bug/patch (original) (raw)

Guido van Rossum guido@python.org
Tue, 05 Nov 2002 17:07:21 -0500

Patch #527371, from Greg Chapman, seems to be pretty obvious, and is laying around for quite some time. The same pattern even happens in a few other places in the sre module. I suggest we apply it, including the fixes for lastindex mentioned in the discussion.

As a minor observation, I'd include the "state->lastmark = lastmark;" line inside the 'if' block when applying, as every other occurence of this algorithm. No big deal, but saves a few cycles.

Just be sure to keep the code compatible with Python 1.5.1 (see PEP 291).

--Guido van Rossum (home page: http://www.python.org/~guido/)