[Python-Dev] Minor issue with PyErr_NormalizeException (original) (raw)

Tim Peters tim.one@comcast.net
Tue, 01 Apr 2003 22:03:45 -0500

[Eric Huss]

We had a bug in one of our extension modules that caused a core dump in PyErrNormalizeException(). At the very top of the function (line 133) it checks for a NULL type. I think it should have a "return" here so that the code does not continue and thus dump core on line 153 when it calls PyClassCheck(type). This should also make the comment not lie about dumping core. ;)

Just thought I'd pass it on..

I agree the code doesn't make sense, but the comment doesn't either. I'm in favor of replacing the guts of the

 if (type == NULL) {

block with a call to Py_FatalError().