[Python-Dev] Failin tests on Windows (original) (raw)

Brett Cannon drifty@alum.berkeley.edu
Fri, 25 Apr 2003 16:54:34 -0700 (PDT)


[Guido van Rossum]

> [Guido van Rossum] > Didn't even think of that problem when I wrote the tests. Should I > patch the docs for urllib (again =) to say that files are open in > binary? I know I wasn't expecting urllib to open in binary mode for > a local text file.

It's a good idea to document that urllib (currently!) never does newline translation. Given that URLs often point to binary files, that's probably a good idea!

OK. I will patch the docs and the docstrings (and backport it as necessary) after you raise the commit moratorium.

> Thanks for fixing this, Guido. I think I am going to do a self-imposed > "no checkins within 24 hours of a planned release" rule.

Yeah, me too. :-)

Perhaps this should be in the FAQ?

-Brett