[Python-Dev] Re: Update PEP 292 (original) (raw)

Barry Warsaw barry at python.org
Fri Aug 20 17:08:15 CEST 2004

On Thu, 2004-08-19 at 19:12, Brett C. wrote:

Got an implementation and it's simple. =) It only required one additional group at the end (r"(?<!$)($)$") in the regex and a test if it matched.

I tested against "$$" to be fine but for "blah "and"" and ""and"" to raise an exception. Those all work and the tests in testpep292 all pass.

What do you think about this compared to Tim's pattern, which is more strict than just complaining about $'s at the end of strings?

If Barry is okay with this I can apply the patch and update the tests and the PEP. Do need to know what exception to raise when this does occur, though. ValueError?

ValueError seems right to me.

-Barry

-------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 307 bytes Desc: This is a digitally signed message part Url : http://mail.python.org/pipermail/python-dev/attachments/20040820/131a7810/attachment.pgp

More information about the Python-Dev mailing list