[Python-Dev] Anyone object to a rewrite of site.py? (original) (raw)

Brett C. bac at OCF.Berkeley.EDU
Mon May 31 15:41:05 EDT 2004


At PyCON I rewrote site.py . The biggest change is that I broke it into functions and moved it over to use sets. Basically the file was just old and I brought it up to modern usage. Performance-wise I can't see a real difference between the current version and my rewrite by executing time ./python.exe -c "pass"; fluctuations in values are standard white noise. Breaking it up into functions also allowed me to write a test suite for site.py .

Patch 921793 (http://www.python.org/sf/921793) has the patch of my rewrite. Does anyone object to me applying the patch? Of course I would love to have someone take a look at the code since this gets executed every time. I have been using the rewritten version since PyCON (so about two months) and I haven't had a bug yet.

Obviously I would like to get this into 2.4a1 to get as much testing as possible.

-Brett



More information about the Python-Dev mailing list