[Python-Dev] Re: [Csv] csv module TODO list (original) (raw)

Skip Montanaro skip at pobox.com
Wed Jan 5 20:34:09 CET 2005 

>> * is CSV going to be maintained outside the python tree?
>> If not, remove the 2.2 compatibility macros for: PyDoc_STR,
>> PyDoc_STRVAR, PyMODINIT_FUNC, etc.

Andrew> Does anyone thing we should continue to maintain this 2.2
Andrew> compatibility?

With the release of 2.4, 2.2 has officially dropped off the radar screen, right (zero probability of a 2.2.n+1 release, though the probability was vanishingly small before). I'd say toss it. Do just that in a single checkin so someone who's interested can do a simple cvs diff to yield an initial patch file for external maintenance of that feature.

>> * inline the following functions since they are used only in one
>> place get_string, set_string, get_nullchar_as_None,
>> set_nullchar_as_None, join_reset (maybe)

Andrew> It was done that way as I felt we would be adding more getters
Andrew> and setters to the dialect object in future.

The only new dialect attribute I envision is an encoding attribute.

>> * is it necessary to have Dialect_methods, can you use 0 for tp_methods?

Andrew> I was assuming I would need to add methods at some point (in
Andrew> fact, I did have methods, but removed them).

Dialect objects are really just data containers, right? I don't see that they would need any methods.

>> * remove commented out code (PyMem_DEL) on line 261
>> Have you used valgrind on the test to find memory overwrites/leaks?

Andrew> No, valgrind wasn't used.

I have it here at work. I'll try to find a few minutes to run the csv tests under valgrind's control.

Skip

More information about the Python-Dev mailing list