[Python-Dev] Twisted and Python 2.5a0r43587 (original) (raw)

"Martin v. Löwis" martin at v.loewis.de
Tue Apr 4 20:37:55 CEST 2006

Thomas Wouters wrote:

And so I could. testbanana.CananaTestCase.testCrashNegativeLong crashes, because it calls PyStringAsStringAndSize() with an int-ptr as second argument (an adjacent ptr variable becomes garbage.) That's certainly a problem with the Pyssizet change. Martin, aren't all output variables (or ptr-variables, rather) supposed to be controlled by the 'PYSSIZETCLEAN' #define? People aren't going to notice their compiler warnings; I know I didn't :)

No: this is the discussion I had with MAL. You have to watch for compiler warnings talking about incorrect pointer types. These days, you can apply Fredrik's checker to find out that you are using functions that output Py_ssize_t.

Ignoring the warning might cause crashes on 64-bit machines. On 32-bit machines, there should be any negative consequence.

Regards, Martin

More information about the Python-Dev mailing list