[Python-Dev] Pervasive socket failures on Windows (original) (raw)

"Martin v. Löwis" martin at v.loewis.de
Sat Feb 11 14:59:26 CET 2006

Ronald Oussoren wrote:

If I understand this discussion correctly that code that would be conditionalized using this define is the ISSELECTABLE macro in selectmodule.c and very simular code in other modules. I'd say that calling the test PyISSELECTABLE and putting it into pyport.h as Tim mentioned in an aside seems to be a good solution. At the very least it is a lot nicer than defining a very long name in pyconfig.h and then having very simular code in several #if blocks.

For the moment, I have committed Tim's original proposal. Moving the macro into pyport.h could be done in addition. That should be done only if selectmodule is also adjusted; this currently tests for _MSC_VER.

Regards, Martin

More information about the Python-Dev mailing list