[Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c (original) (raw)
Jeremy Hylton jeremy at alum.mit.edu
Tue Jan 3 02:23:20 CET 2006
- Previous message: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c
- Next message: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
On 1/2/06, Neal Norwitz <nnorwitz at gmail.com> wrote:
On 1/2/06, Barry Warsaw <barry at python.org> wrote: > I think we have a fundamental problem with Python-ast.c and > Python-ast.h. These files should not be both auto-generated and checked > into Subversion.
I agree with the problem statement. > The general rule should be that no file that is ever generated can be > checked into Subversion. Probably the right approach is to check in a > template file that will not get removed by a distclean, and modify the > build process to generate Python-ast.* from those template files. I'm not sure about your proposed solution, though. There's a bootstrapping issue. Python-ast.[ch] are generated by a python 2.2+ script. /f created a bug report if only 2.1 is available. The Python-ast.[ch] should probably not be removed by distclean. This is similar to configure. Would that make you happy? What else would improve the current situation?
I think this solution is better. It's relatively rare for people to change the ast definition, so for most purposes these should be static files.
Jeremy
- Previous message: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c
- Next message: [Python-Dev] [Python-checkins] commit of r41880 - python/trunk/Python/Python-ast.c
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]