[Python-Dev] [PATCH] Fix dictionary subclass semantics whenused as global dictionaries (original) (raw)
Crutcher Dunnavant crutcher at gmail.com
Thu Jan 12 22:54:24 CET 2006
- Previous message: [Python-Dev] [PATCH] Fix dictionary subclass semantics whenused as global dictionaries
- Next message: [Python-Dev] [PATCH] Fix dictionary subclass semantics whenused as global dictionaries
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
I sorta disagree about it not being broken. Adding a feature which works for eval but not for exec seems pretty broken. It's difficult to reason about what will happen in the exec context, so I can't see what fixing it would endanger; but I'd deffinately like to see it for 2.5.
I've run rough timings on the code, ('test make time'), detailed in the patch discussion, and it seems completely lost in the noise.
On 1/12/06, Raymond Hettinger <raymond.hettinger at verizon.net> wrote:
> Is there any objection to this patch? Any support?
It is assigned to me. When I have time, will go through it in detail (the given use cases, more detailed timings, and a close reading of the code). If accepted, it will be for Py2.5, as it is a new feature. There is nothing broken about the existing eval() version, it just doesn't apply as broadly as you would have liked.
Raymond
-- Crutcher Dunnavant <crutcher at gmail.com> monket.samedi-studios.com
- Previous message: [Python-Dev] [PATCH] Fix dictionary subclass semantics whenused as global dictionaries
- Next message: [Python-Dev] [PATCH] Fix dictionary subclass semantics whenused as global dictionaries
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]