[Python-Dev] Fix for Lib/test/leakers/test_gestalt.py (original) (raw)
Thomas Heller theller at python.net
Mon Jul 10 23:51:28 CEST 2006
- Previous message: [Python-Dev] Fix for Lib/test/leakers/test_gestalt.py
- Next message: [Python-Dev] Autoloading? (Making Queue.Queue easier to use)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Thomas Heller schrieb:
I think this fixes the leak in Lib/test/leakers/testgestalt.py.
Index: Python/mactoolboxglue.c =================================================================== --- Python/mactoolboxglue.c (revision 50522) +++ Python/mactoolboxglue.c (working copy) @@ -60,8 +60,9 @@ strncpy(buf, input, sizeof(buf) - 1); buf[sizeof(buf) - 1] = '\0'; } + PyDECREF(rv); } - + PyXDECREF(m); return buf; }
I'm less sure about this one, but it looks like the DECREF is also required:
(Here's the patch that I really meant)
Index: Mac/Modules/macosmodule.c
--- Mac/Modules/macosmodule.c (Revision 50515) +++ Mac/Modules/macosmodule.c (Arbeitskopie) @@ -375,6 +375,7 @@ /* And try again... / h = GetResource('Estr', err); } + Py_DECREF(m); } } /
Thomas
- Previous message: [Python-Dev] Fix for Lib/test/leakers/test_gestalt.py
- Next message: [Python-Dev] Autoloading? (Making Queue.Queue easier to use)
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]