[Python-Dev] Let's stop eating exceptions in dict lookup (original) (raw)
Armin Rigo arigo at tunes.org
Mon May 29 21:50:50 CEST 2006
- Previous message: [Python-Dev] Let's stop eating exceptions in dict lookup
- Next message: [Python-Dev] test_gzip/test_tarfile failure om AMD64
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]
Hi Guido,
On Mon, May 29, 2006 at 12:34:30PM -0700, Guido van Rossum wrote:
+1, as long as (as you seem to imply) PyDictGetItem() still swallows all exceptions.
Yes.
Fixing PyDictGetItem() is a py3k issue, I think. Until then, there are way too many uses. I wouldn't be surprised if after INCREF and DECREF it's the most commonly used C API method...
Alternatively, we could add a new C API function, and gradually replace PyDict_GetItem() uses with the the new one. I can't think of an obvious name, though...
Maybe code should just start using PyMapping_GetItem() instead. It's not incredibly slower than PyDict_GetItem(), at least in the non-KeyError case.
A bientot,
Armin
- Previous message: [Python-Dev] Let's stop eating exceptions in dict lookup
- Next message: [Python-Dev] test_gzip/test_tarfile failure om AMD64
- Messages sorted by: [ date ] [ thread ] [ subject ] [ author ]